Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[edge browsers]: filter out by userAgent #26

Merged
merged 1 commit into from May 5, 2017
Merged

[edge browsers]: filter out by userAgent #26

merged 1 commit into from May 5, 2017

Conversation

legomushroom
Copy link
Contributor

The 'WebkitAppearance' in document.documentElement.style check returns true for all Edge browsers, at the same time console styling is “work in progress” for the Edge and isn’t supported yet. Thus this results in broken console message.

This PR filters out all Edge browsers. This should be revisited when the feature will get better support (recheck at October 2017).

gr2m
gr2m approved these changes May 5, 2017
View reviewed changes
Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a ton! New release is coming up :)

@gr2m gr2m merged commit 79adee8 into gr2m:master May 5, 2017
@legomushroom
Copy link
Contributor Author

Awesome, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@legomushroom @gr2m