Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3.5 breaking change #125

Closed
2 of 5 tasks
abraham opened this issue Jul 18, 2023 · 2 comments · Fixed by #129
Closed
2 of 5 tasks

v3.3.5 breaking change #125

abraham opened this issue Jul 18, 2023 · 2 comments · Fixed by #129
Labels
bug Something isn't working released

Comments

@abraham
Copy link

abraham commented Jul 18, 2023

Please avoid duplicates

Reproducible test case

No response

Please select the environment(s) that are relevant to your bug report

  • Browsers
  • Node
  • Deno

Versions

v3.3.5

What happened?

Upgrade from v3.3.4 to v3.3.5 in a node16 environment. I expect github-project to keep working but octokit/app drops support for node 14 & 16 among other breaking changes.

Would you be interested in contributing a fix?

  • yes
@abraham abraham added the bug Something isn't working label Jul 18, 2023
@gr2m
Copy link
Owner

gr2m commented Aug 4, 2023

our tests still pass so we should be fine. But I'll revert it anyway just to avoid future surprises and release a breaking change that drops node 16 as well

@github-actions
Copy link

🎉 This issue has been resolved in version 3.3.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants