Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript): declarations #77

Merged
merged 2 commits into from
May 26, 2020
Merged

feat(typescript): declarations #77

merged 2 commits into from
May 26, 2020

Conversation

Fleuv
Copy link
Contributor

@Fleuv Fleuv commented May 23, 2020 •
edited
Loading

In response to #76

@gr2m gr2m changed the title Added type declarations feat(typescript): declarations May 24, 2020
@gr2m
Copy link
Owner

gr2m commented May 24, 2020

Do we need to add a "types" key to package.json? Or will it look for the index.d.ts by default?

@Fleuv
Copy link
Contributor Author

Fleuv commented May 25, 2020 •
edited
Loading

Indeed according to this article you need to add the "types" key. One second I will update this PR...

gr2m
gr2m approved these changes May 26, 2020
View reviewed changes
Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@gr2m gr2m merged commit f876c85 into gr2m:master May 26, 2020
@gr2m
Copy link
Owner

gr2m commented May 26, 2020

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m gr2m added the released label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fleuv @gr2m