-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all known issues for Hoodie Camp Release #88
Comments
@codyzu these 3 issues are all related to username change:
here is some background information on it: You can un-skip this test in hoodiehq/hoodie-account to make sure it all works together. To set it up locally, git clone the three repos, then run Let me know if you want to give this a try, or if you have any farther questions |
@gr2m I'll start looking at the details today... I won't have any results until wednesday (when I have some hours reserved for this) 👍 |
okay, wow, I guess that’s it :) The remaining issues can be done as part of the next release :) |
follow up for #87
Ready
hoodie.account.signOut()
must resolve with account properties, currently is undefinedPUT /session to return 401 Unauthorized error when user cannot be found
Implement PATCH /session/account route
Implement
hoodie.account.update(changedProperties)
implement
hoodie.account.destroy()
hoodie.account.fetch()
,.update()
,.profile.fetch()
and.profile.update()
should fail with UnauthenticatedError if session is invalid, but currently fails with "Not FoundError"Implement
hoodie.account.isUnauthenticated()
reauthenticate
event when unauthenticated hoodiehq/hoodie-account-client#57Implement
reauthenticate
eventReturn custom Conflict error
Return custom Not Found error
Implement
hoodie.store.isPersistent()
Reset
hoodie.store
correctly onsignout
eventstore.connect()
hoodiehq/hoodie-client#45Reset
hoodie.store
onsignin
eventpass options.hooks to signup / signin / signout events
trigger "update" event when account.update succeeds
renew session after changing username / password
call hoodie.store.connect() on page load if user is signed in
Implement username change
x-set-session
response header hoodiehq/hoodie-account-client#75account.update
: set session ID fromx-set-session
response headerx-set-session
header hoodiehq/hoodie-account-server#80PATCH /session/account: respond with
x-set-session
headerGET, PATCH, DELETE /session/account sould respond with 401 Invalid session, not 404 Not found
Store Server: Proxy to PouchDB instance
rename
/hoodie/bundle.js
to/hoodie/client.js
rename
/www
folder to/public
simplify Internal Module Architecture
make the Hoodie fallback webapp more helpful
Tracker app: items are disappearing after I log out and log back in
Needs instructions
unify test setup
remove /session/account from spec
Inconsistencies between implementation and API spec
Discussion
how to add a .createdBy property automagically to all documents created with hoodie.store.add?
rename
bearer
in ourAuthorization
header tosession
, because that’s what it is, and we don’t use bearer tokens anywhere else in our code. It’s unnecessary confusing. So instead ofAuthorization: bearer sessionid123
header, we would haveAuthorization: session sessionid123
The text was updated successfully, but these errors were encountered: