Allow user to optionally pass file mode #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the user to specify file mode for each file in a change. By default, the file mode for a file is 100644. An user can specify the file mode in addition to the content and the encoding.
|
PR looks great, thank you Kenneth! Could you please update the README to include a file setting the file mode? You can use the same example you used in the tests |
|
🎉 This PR is included in version 3.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kennethzfeng
changed the title
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to specify file mode for each file in
a change.
By default, the file mode for a file is 100644. An user can specify
the file mode in addition to the content and the encoding.
I tested this change manually using the script to capture fixtures. This works as expected, the fixture PR.
The change is revised based on the prior work from #32. Thanks, @LucaLanziani