-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: explicitly log authentication errors as warnings #72
feat: explicitly log authentication errors as warnings #72
Conversation
0971d64
to
2303a36
Compare
…n-errors-as-warnings
@luca-gr4vy I think this works, but doesn't EmbedUI know the ID from the host it's loaded on? Not sure what makes more sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :-) Before you hit merge though - See https://github.com/gr4vy/gr4vy-embed/blob/main/CONTRIBUTING.md#releasing-a-pr (I think internal
is the correct label)
@cbetta the following is taken from the dashboard codebase (it's how the Integrations page shows the id)
though, I believe getting it directly from the embed's config should be more robust (?) |
Agreed. Keep it as-is. |
🚀 PR was released in |
Description: Adds
gr4vyId
to the options object passed to the embed, for debugging purposes.Ticket: https://gr4vy.atlassian.net/browse/TA-1026
Screenshot(s):