Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add approval ui dimensions #88

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Conversation

douglaseggleton
Copy link
Collaborator

@douglaseggleton douglaseggleton commented Jun 7, 2022

Adds popup dimension configuration or fallback to standard size.

Release notes

Adds the capability for popup redirects to have a custom size set by individual payment processors.

packages/embed/src/popup/popup.ts Outdated Show resolved Hide resolved
packages/embed/webpack.dev.js Show resolved Hide resolved
Copy link
Contributor

@luca-gr4vy luca-gr4vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@douglaseggleton douglaseggleton added release Create a release when this pr is merged internal Changes only affect the internal API patch Increment the patch version when merged labels Jun 10, 2022
@douglaseggleton douglaseggleton merged commit 5de311b into main Jun 10, 2022
@douglaseggleton douglaseggleton deleted the TA-1387-popup-dimensions branch June 10, 2022 10:09
@gr4vy-code
Copy link
Collaborator

🚀 PR was released in v2.11.6 🚀

@gr4vy-code gr4vy-code added the released Issue or pull request released label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API patch Increment the patch version when merged release Create a release when this pr is merged released Issue or pull request released
Development

Successfully merging this pull request may close these issues.

None yet

4 participants