Permalink
Browse files

width="auto" is not valid HTML5 value for attribute (Syntax of non-ne…

…gative integer:

One or more digits (0–9). For example: 42 and 0 are valid, but -273). 
Not sure what the width is used for in the embed of the SWF here, is it needed?
  • Loading branch information...
grEvenX
grEvenX committed Feb 7, 2012
1 parent fa9c78c commit 6f30fb600598d8618efec2a010ba1a69c5b75694
Showing with 1 addition and 1 deletion.
  1. +1 −1 script/soundmanager2.js
View
@@ -4409,7 +4409,7 @@ function SoundManager(smURL, smID) {
localURL = (_s.altURL || remoteURL),
swfTitle = 'JS/Flash audio component (SoundManager 2)',
oEmbed, oMovie, oTarget = _getDocument(), tmp, movieHTML, oEl, extraClass = _getSWFCSS(),
s, x, sClass, side = 'auto', isRTL = null,
s, x, sClass, side = '1', isRTL = null,
html = _doc.getElementsByTagName('html')[0];
isRTL = (html && html.dir && html.dir.match(/rtl/i));

1 comment on commit 6f30fb6

@scottschiller

This comment has been minimized.

Show comment
Hide comment
@scottschiller

scottschiller Feb 11, 2012

Good find, thanks for the note.

Width calculations are important to the SWF here. If "1" is specified, the SWF will probably end up as 1x1 instead of (potentially) inheriting from CSS, and that can affect performance in some cases (where the SWF needs to be at least 6x6.) I may simply remove the width/height stuff to work around this.

scottschiller commented on 6f30fb6 Feb 11, 2012

Good find, thanks for the note.

Width calculations are important to the SWF here. If "1" is specified, the SWF will probably end up as 1x1 instead of (potentially) inheriting from CSS, and that can affect performance in some cases (where the SWF needs to be at least 6x6.) I may simply remove the width/height stuff to work around this.

Please sign in to comment.