Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Would it be possible to create a version for JDK17? #40

Open
Yaytay opened this issue Apr 11, 2022 · 2 comments
Open

Would it be possible to create a version for JDK17? #40

Yaytay opened this issue Apr 11, 2022 · 2 comments

Comments

@Yaytay
Copy link

Yaytay commented Apr 11, 2022

I thought I'd got my build working with JDK17 following your example (using Zulu on Windows), but when I run in GitHub Actions (Zulu on Ubuntu) Surefire bombs out with the message: Cannot use JVMCI compiler: No JVMCI compiler found.
It is unclear what the implications of removing JVMCI are for polyglot programming on OpenJDK.

@Yaytay
Copy link
Author

Yaytay commented Apr 11, 2022

Oh, actually I think I might have just resolved my issue.
In the pom you have:
--upgrade-module-path=${compiler.dir}/compiler.jar:${compiler.dir}/compiler-management.jar
To work on Windows that needs a semicolon:
--upgrade-module-path=${compiler.dir}/compiler.jar;${compiler.dir}/compiler-management.jar

The docs (https://docs.oracle.com/en/java/javase/17/docs/specs/man/java.html) are quite specific that is should be a semicolon, but that definitely doesn't work on Linux.
Fortunately the docs also state that it's a list of directories, so this seems to work:
--upgrade-module-path=${compiler.dir}

@stanio
Copy link

stanio commented May 10, 2023

I guess this has been adjusted in b690c6c, now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants