-
Notifications
You must be signed in to change notification settings - Fork 27
Add --disable-warnings-as-errors option to build_labsjdk.py #7
Conversation
…arnings-as-errors
It would be even better if we added a general purpose |
To be honest I want to pass through all arguments to configure script in JDK, however it is difficult to use I want to pass configure options to arguments, but if it is difficult, we may set configure options to file and build_labsjdk.py would pickup it. What do you think? configuration file:
Run build_labsjdk.py with configuration file:
|
The configure options file idea sounds good. Stepping back, can you say more about your use case for |
I sometimes tweak configure options for OpenJDK e.g. I want to build / debug GraalVM on Fedora 32 because it provides modern C++ compiler and native debugger. But we need to tweak configure options for them due to compiler warnings. |
Also I want to backport some tickets for jdk/jdk to build LabsJDK on Fedora 32 - I've listed them on #6. |
I guess my real question is why you need to use |
README.md says LabsJDK can be built with I'd like you to add (and maintain) what options should we pass to configure script in README.md if we do not change |
Please update this PR to implement the configure options file and I'll integrate it. |
I pushed new commit. Could you review it? I introduced new option
|
Looks good - I'll integrate this. |
If you don't mind, I will squash the commits in this PR when merging them. |
@dougxc Thanks! please squash and merge this PR. |
Resolved by 6bc9013 |
I'd like to introduce
--disable-warnings-as-errors
tobuild_labsjdk.py
.I tried to build LabsJDK CE 11 on Fedora 32 which is installed GCC 10.1.1, but GCC reported some warnings, and they were considered to be errors.
configure script in OpenJDK has
--disable-warnings-as-errors
option to avoid them, so I want to pass it frombuild_labsjdk.py
.