-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.1] Backport --no-jlinking fixes from 24.0 #651
[23.1] Backport --no-jlinking fixes from 24.0 #651
Conversation
Use the approach of 24.0 instead. This reverts commit 588ae3a.
(cherry picked from commit 4711d66)
(cherry picked from commit ee34fb4)
(cherry picked from commit 77deacb)
(cherry picked from commit 8882a7c)
(cherry picked from commit f8978ee)
(cherry picked from commit d38dd40)
(cherry picked from commit 38eb6df)
(cherry picked from commit a9686e2)
(cherry picked from commit f8e9650)
…geModulePath is empty (cherry picked from commit ffdd704)
(cherry picked from commit 04a68ca)
(cherry picked from commit 8ce7298)
(cherry picked from commit c629a5c)
(cherry picked from commit 744bafb)
(cherry picked from commit b764ee7)
(cherry picked from commit 4b6d8b8)
(cherry picked from commit c6bdbb6)
(cherry picked from commit 261dd42)
(cherry picked from commit 0c518c7)
The two test failures are:
=> Looks like we need a fix similar to quarkusio/quarkus#37813, but for
|
Re-running CI so as to verify that quarkusio/quarkus#37879 fixed the IT Data 5 failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jerboaa
Lerge merge it once the CI run ends.
Only the one known failure of IT main remained. That's: quarkusio/quarkus#37809 Merging. |
This PR does the following things:
This now removes the old agent-based native image build in our 23.1.2 release, but it should be OK because it's unlikely any quarkus user is using it. It's a needed change in order to not drag in some ByteBuffer classes into the image heap when generating the native image agent.