Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeImagePlugin configures wrong test results dir #218

Closed
oehme opened this issue Feb 23, 2022 · 1 comment · Fixed by #219
Closed

NativeImagePlugin configures wrong test results dir #218

oehme opened this issue Feb 23, 2022 · 1 comment · Fixed by #219
Labels
bug Something isn't working gradle-plugin Related to Gradle plugin

Comments

@oehme
Copy link

oehme commented Feb 23, 2022

native-build-tools/native-gradle-plugin/src/main/java/org/graalvm/buildtools/gradle/NativeImagePlugin.java

Line 384 in 4f02438

test.getOutputs().dir(testResultsDir);

This makes the global test results dir an output, which means it will overlap with every other Test task in the project, preventing caching.
@melix
Copy link
Collaborator

melix commented Feb 23, 2022

Oh good catch, it should have been the test list file instead.

@lazar-mitrovic lazar-mitrovic added bug Something isn't working gradle-plugin Related to Gradle plugin labels Feb 23, 2022
melix added a commit that referenced this issue Feb 25, 2022
@melix
Fix incorrect declaration of output directory
0f67d41 
This commit fixes an issue with the Gradle plugin where the directory
where test ids are generated was incorrectly declared as an output of
the test task. This caused independent test tasks to be out-of-date
when they shouldn't.

Fixes #218
@melix melix mentioned this issue Feb 25, 2022
Merged
melix added a commit that referenced this issue Feb 25, 2022
@melix
Fix incorrect declaration of output directory
c48eb7b 
This commit fixes an issue with the Gradle plugin where the directory
where test ids are generated was incorrectly declared as an output of
the test task. This caused independent test tasks to be out-of-date
when they shouldn't.

Fixes #218
melix added a commit that referenced this issue Feb 25, 2022
@melix
Fix incorrect declaration of output directory
16ef948 
This commit fixes an issue with the Gradle plugin where the directory
where test ids are generated was incorrectly declared as an output of
the test task. This caused independent test tasks to be out-of-date
when they shouldn't.

Fixes #218
melix added a commit that referenced this issue Feb 28, 2022
@melix
Fix incorrect declaration of output directory
aa743fe 
This commit fixes an issue with the Gradle plugin where the directory
where test ids are generated was incorrectly declared as an output of
the test task. This caused independent test tasks to be out-of-date
when they shouldn't.

Fixes #218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gradle-plugin Related to Gradle plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect declaration of output directory graalvm/native-build-tools
3 participants
@melix @oehme @lazar-mitrovic