Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong error message when agent output is missing (Gradle plugin) #65

Closed
lazar-mitrovic opened this issue Jun 22, 2021 · 1 comment
Closed

Wrong error message when agent output is missing (Gradle plugin) #65

lazar-mitrovic opened this issue Jun 22, 2021 · 1 comment
Assignees
@lazar-mitrovic
Labels
bug Something isn't working
Milestone
0.9.1

Comments

@lazar-mitrovic
Copy link
Collaborator

native-build-tools/native-gradle-plugin/src/main/java/org/graalvm/buildtools/gradle/dsl/NativeImageOptions.java

Lines 184 to 186 in 9120801

if (!agentOutput.toFile().exists()) {
throw new GradleException("Agent output missing while `agent` option is set.\n" +
"Did you run the test task before with `-Pagent` enabled?");

These lines assume that user tries to run nativeTest even when user tries to invoke nativeBuild.
@lazar-mitrovic lazar-mitrovic mentioned this issue Jun 22, 2021
Closed
@lazar-mitrovic lazar-mitrovic added this to the 0.9.1 milestone Jun 22, 2021
@lazar-mitrovic lazar-mitrovic self-assigned this Jun 22, 2021
@lazar-mitrovic lazar-mitrovic added the bug Something isn't working label Jun 22, 2021
@lazar-mitrovic lazar-mitrovic mentioned this issue Jun 22, 2021
Merged
lazar-mitrovic added a commit that referenced this issue Jun 22, 2021
@lazar-mitrovic
Javadoc and other NativeImageOptions fixes (#69)
aa4b041 
Add/clarify Javadoc in the NativeImageOptions class wherever needed.
Add @deprecated tag to options that are there only for compatibilty with older Gradle plugins.
Use only recommended options internally in order to be consistent.

Closes following issues:
Fixes User native-image arguments should override plugin arguments in the gradle plugin #64
Fixes Wrong error message when agent output is missing (Gradle plugin) #65
Fixes systemProperties javadoc is not clear enough (Gradle plugin) #66
@lazar-mitrovic
Copy link
Collaborator Author

Fixed by aa4b041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazar-mitrovic lazar-mitrovic

Labels
bug Something isn't working
Projects
None yet
Milestone
0.9.1
Development

No branches or pull requests
1 participant
@lazar-mitrovic