Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock when collecting metadata #391

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Fix deadlock when collecting metadata #391

merged 1 commit into from
Jan 30, 2023

Commits on Jan 24, 2023

  1. Fix deadlock when collecting metadata

    The reachability metadata service is not thread-safe, but it is
    possible for it to be called from multiple tasks in a multi-project.
    It this happens, then a deadlock may happen, or weird errors with
    a property not set can be thrown at the user.
    
    This fixes the problem by making sure only a single task can
    access the service concurrently. Ideally, the service should be
    reworked to allow concurrent access, but it's quite some work
    since it involves locking access to the repository (typically
    to download and unzip metadata).
    
    Fixes #387
    melix committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a47592e View commit details
    Browse the repository at this point in the history