Simplify ordered float comparisons and add test cases #235
Conversation
See a3c9b3e for the ordered double comparison simplification.
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I don't know if it's worth profiling at this point? Or is this compare node only ever used in cases which will profile anyway, like conditional jumps?
There was a problem hiding this comment.
If the comparison is used in an branch, then the branch probability profiling that is already injected in the successor selection should suffice. However, the value could also be stored into the frame or somewhere else, and then used at a different location. Do you think that branch probability injection could improve performance in this case?
There was a problem hiding this comment.
In Ruby in general if we have an if statement that we don't expect to always be a constant in code that is being PEd, we will use a profile.
There was a problem hiding this comment.
Isn't this somehow a larger design question?
Do you profile your conditions/logic nodes or do you profile the things that use them (such as branching control-flow nodes)
There was a problem hiding this comment.
IMHO, the latter (branching control flow). Profiling the input condition of an if is a convenient way to do that but the profile still belongs to the if (and its node), not the condition.
No description provided.