This repository has been archived by the owner on Aug 22, 2019. It is now read-only.
value profiling for float, double, and remaining integer types #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public double executeDouble(VirtualFrame frame) { | ||
| double value = LLVMMemory.getDouble(addressNode.executePointee(frame)); | ||
| if (value == profiledValue) { |
There was a problem hiding this comment.
Using == here might cause you problems. For example -0.0 == 0.0, but it's not the case for every operator that f(-0.0) == f(0.0). You probably want to compare the bits instead, using Double.toLongBits.
However, Truffle already has classes for value profiling (which gets this right). Maybe use those?
There was a problem hiding this comment.
Good point! I would suggest that I first push the fix for this, and then I will finish the travis configuration. When the gate can run the test cases I will refactor the load nodes to use the Truffle value profiling classes.
There was a problem hiding this comment.
if you do this yourself, you should use doubleToRawLongBits - it doesn't normalize NaNs.
chrisseaton
added a commit
that referenced
this pull request
Feb 4, 2016
value profiling for float, double, and remaining integer types
This was referenced Feb 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, value profiling for memory loads has only been performed for I32 and I64 types. This changes adds value profiling for float, double, and the remaining integer types. There are still other loads which are not profiled because it is unclear if there is a benefit (e.g., for pointers).