Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

375/space grid #378

Merged
merged 3 commits into from
Feb 23, 2021
Merged

375/space grid #378

merged 3 commits into from
Feb 23, 2021

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Feb 18, 2021

Space Grid is improved so it:

  • evenly distributed when more than one space is on one row depending on the computer screen
  • does not show strange spaces between rows
  • does not take the full screen if there is only one space on one row (there is some maximum width set)

A maybe strange behavior would be that depending on the card size (which depends whether there is a description or not, the image size perhaps) the cards might not be aligned vertically, but they still are evenly distributed horizontally.

Forcing the vertical alignment (set xs=4) would create margin on the right depending on the screen size.

close #375
close #376
close #374

@pyphilia
Copy link
Contributor Author

some screenshots

Screenshot 2021-02-18 at 18 43 07

Screenshot 2021-02-18 at 18 43 27

Screenshot 2021-02-18 at 18 44 02

Copy link
Member

@juancarlosfarah juancarlosfarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pyphilia pyphilia merged commit 30d64cb into master Feb 23, 2021
@pyphilia pyphilia deleted the 375/spaceGrid branch February 23, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants