fix: allow fullscreen for h5p iframe #884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some h5p provide fullscreen feature. Before the fix it resized once and stays like this, it's impossible to revert.
Screen.Recording.2024-05-31.at.11.44.29.mov
I added the
allowFullscreen
prop for the iframe.It does not work perfectly, one click over three resize weirdly.
Without this change, the fullscreen does not work at all, so I guess it's okay as compromise.
I quickly tried to set
height=100%
on fullscreen event, but it didn't work.Screen.Recording.2024-05-31.at.11.43.43.mov