Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow fullscreen for h5p iframe #884

Merged
merged 3 commits into from
Jun 3, 2024
Merged

fix: allow fullscreen for h5p iframe #884

merged 3 commits into from
Jun 3, 2024

Conversation

pyphilia
Copy link
Contributor

Some h5p provide fullscreen feature. Before the fix it resized once and stays like this, it's impossible to revert.

Screen.Recording.2024-05-31.at.11.44.29.mov

I added the allowFullscreen prop for the iframe.
It does not work perfectly, one click over three resize weirdly.

Without this change, the fullscreen does not work at all, so I guess it's okay as compromise.
I quickly tried to set height=100% on fullscreen event, but it didn't work.

Screen.Recording.2024-05-31.at.11.43.43.mov

@pyphilia pyphilia requested review from spaenleh and ReidyT May 31, 2024 09:47
@pyphilia pyphilia self-assigned this May 31, 2024
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a question about the last video. With this change, the user can easily enter in fullscreen, but then he has to click twice to exit this mode ?

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! I had a user show me this behaviour too, nice that you were able to fix it.

@pyphilia
Copy link
Contributor Author

pyphilia commented Jun 3, 2024

I just have a question about the last video. With this change, the user can easily enter in fullscreen, but then he has to click twice to exit this mode ?

yes that's the only pb =/

@pyphilia pyphilia added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit f8169dd Jun 3, 2024
3 checks passed
@pyphilia pyphilia deleted the h5p-iframe branch June 10, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants