Use rules_kotlin >= 1.5.0 format changes #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minkuan88
force-pushed
the
accomodate-rules-kotlin-1.5.0
branch
from
99b7c86
to
7841f79
Compare
grazel-gradle-plugin/src/main/kotlin/com/grab/grazel/bazel/rules/KotlinRules.kt
Show resolved
Hide resolved
minkuan88
force-pushed
the
accomodate-rules-kotlin-1.5.0
branch
from
7841f79
to
f7bf9f0
Compare
arunkumar9t2
approved these changes
May 10, 2022
akshay-grabtaxi
pushed a commit
that referenced
this pull request
Jun 28, 2023
Use rules_kotlin >= 1.5.0 format changes See #14
akshay-grabtaxi
pushed a commit
that referenced
this pull request
Jun 28, 2023
Use rules_kotlin >= 1.5.0 format changes See #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In order to accommodate rules_kotlin 1.5.0 changes, there is a need to change some of the load() statements to point at different .bzl (e.g. kt_jvm_library would be loaded from jvm.bzl instead of kotlin.bzl).
There is also a helper function (
kotlinc_version) that was added to help in choosing compiler versionsTesting
Issues Fixed