Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build_path to look in domains #78

Closed
tyarkoni opened this issue Jul 24, 2018 · 0 comments
Closed

Fix build_path to look in domains #78

tyarkoni opened this issue Jul 24, 2018 · 0 comments
Labels

Comments

@tyarkoni
Copy link
Member

Currently, build_path is broken, because the path_patterns in the config files, which used to be stored in the Layout instance, are now tied to individual Domain objects that build_path doesn't check. As a result, Layout.path_patterns is always an empty list. We should add a domains argument to build_path that extracts the specified path_patterns from the passed domains, or uses all available domains if domains=None. See write_contents_to_file for a similar implementation, and bids-standard/pybids#213 for more context.

@tyarkoni tyarkoni added the bug label Jul 24, 2018
tyarkoni added a commit that referenced this issue Jul 24, 2018
Construct path_patterns in build_path via domains; fixes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant