fix: fix React.Fragment complaining about width/height (apache#219)

graceguo-supercat · Sep 4, 2019 · 3e8ca39 · 3e8ca39
1 parent 3cb2beb
commit 3e8ca39
Showing 1 changed file with 23 additions and 18 deletions.
diff --git a/packages/superset-ui-chart/src/components/SuperChart.tsx b/packages/superset-ui-chart/src/components/SuperChart.tsx
@@ -116,29 +116,34 @@ export default class SuperChart extends React.PureComponent<Props, {}> {
       disableErrorBoundary,
       FallbackComponent,
       onErrorBoundary,
-      Wrapper = React.Fragment,
+      Wrapper,
       ...rest
     } = this.props as PropsWithDefault;
 
-    const chart = (
+    const chartWithoutWrapper = (
+      <SuperChartCore
+        ref={this.setRef}
+        id={id}
+        className={className}
+        chartType={chartType}
+        chartProps={this.createChartProps({
+          ...rest,
+          height,
+          width,
+        })}
+        preTransformProps={preTransformProps}
+        overrideTransformProps={overrideTransformProps}
+        postTransformProps={postTransformProps}
+        onRenderSuccess={onRenderSuccess}
+        onRenderFailure={onRenderFailure}
+      />
+    );
+    const chart = Wrapper ? (
       <Wrapper width={width} height={height}>
-        <SuperChartCore
-          ref={this.setRef}
-          id={id}
-          className={className}
-          chartType={chartType}
-          chartProps={this.createChartProps({
-            ...rest,
-            height,
-            width,
-          })}
-          preTransformProps={preTransformProps}
-          overrideTransformProps={overrideTransformProps}
-          postTransformProps={postTransformProps}
-          onRenderSuccess={onRenderSuccess}
-          onRenderFailure={onRenderFailure}
-        />
+        {chartWithoutWrapper}
       </Wrapper>
+    ) : (
+      chartWithoutWrapper
     );
 
     // Include the error boundary by default unless it is specifically disabled.