New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change redshift interpolation to log(1+z) #126
Conversation
…olation results in negative values when extrapolating to negative redshift.
This fails the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me although before merging, it would be good to get another pair of eyes on the questions I raised in my review. Great job!
This is a reissue of PR #105, which I've taken over for BK. I've merged with the latest changes and made just a couple modifications, but I will leave the rest open for discussion.
The gist of this PR is that it changes the interpolation over redshift for the UV background and tabulated cooling to interpolation over log(1 + z). This is an improvement since all of our redshift-dependent tabular data is evenly spaced in log(1 + z). My recollection is that it was decided at a user/dev meeting to go with this without maintaining an option for the old behavior as it is a general improvement.
This PR also includes changes to the
tiny8
constant and settingedot
to zero when it's very small. These I am less sure of these, but will leave them open for discussion.