Fixing lifetime issue for grackle_data_path in the Cython Grackle wrapper #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pper Previously the underlying chemistry_data struct was invalidated if the bytearray used to specify the grackle_data_path was garbage collected
mabruzzo
force-pushed
the
pygrackle_filepath_bugfix
branch
from
b9f2352
to
207b099
Compare
gregbryan
approved these changes
Jan 31, 2021
|
This issue has annoyed me for ages! Thanks fixing it once and for all. |
brittonsmith
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the underlying
chemistry_datastruct was invalidated if the bytearray used to specify thegrackle_data_pathwas garbage collected. The cause of this is discussed at the end of this section of the Cython documentationI have a couple other minor tweaks that may be worth introducing to Grackle. But those are probably worth discussing offline, before I put them together in a PR.