Fix velocity_units in freefall.py #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ample file freefall.py.
brittonsmith
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
I've checked throughout the code for how velocity units are defined and I see it being done this way (the way it's been changed to) consistently for proper coordinates. I think this is right, or at least completely consistent with how we do it everywhere else, so I'm going to pull this in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the pygrackle example file freefall.py velocity_units were defined with a factor of a_value. This was not consistent with the units being input as proper coordinates. This factor of a_value is now removed so all unit definitions are consistent.