Make test prefix msg configurable #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Failed, because it is two words, is harder to parse from the failure message itself. I think it is better to for the first word to be as descriptive as possible, so students can easily scan for the word "Fail" on the far left side.
isaacl
force-pushed
the
statusMessage
branch
from
f1b598b
to
e171481
Compare
|
Hmm, that's an interesting idea, though it's kind of subjective in my opinion. What if instead of having it hardcoded, we make it configurable by passing in an argument to the JSONTestRunner class, say |
isaacl
changed the title
|
done! |
ibrahima
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Failed, because it is two words, is harder to parse from the
failure message itself. I think it is better to for the first word
to be as descriptive as possible, so students can easily scan for
the word "Fail" on the far left side.
Maybe it's subjective! Make it configurable.