Skip to content

Commit

Permalink
improve visual ci config (#7275)
Browse files Browse the repository at this point in the history
* fix

* fix
  • Loading branch information
pngwn authored and Ali Abid committed Feb 4, 2024
1 parent f5c5de2 commit 37d4700
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/actions/changes/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,4 +148,4 @@ runs:
type: ${{ inputs.type }}
init: true
mergeable: ${{ steps.pr.outputs.source_branch == 'main' || steps.pr.outputs.mergeable }}
commit_status: ${{ inputs.commit_status }}
commit_status: ${{ inputs.type == 'visual' && steps.should_run.outputs.should_run == 'false' || inputs.commit_status }}
12 changes: 0 additions & 12 deletions .github/workflows/deploy+test-visual.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,18 +86,6 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
onlyChanged: true
exitOnceUploaded: true
- name: do check
if: always()
uses: "gradio-app/github/actions/commit-status@main"
with:
type: "visual"
token: ${{ secrets.GITHUB_TOKEN }}
pr: ${{ needs.changes.outputs.pr_number }}
sha: ${{ needs.changes.outputs.sha }}
name: "test / visual"
result: ${{ job.status }}
job_id: "test-visual"
url: ${{ steps.publish-chromatic.outputs.buildUrl }}

comment-chromatic-end:
uses: "./.github/workflows/comment-queue.yml"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,4 @@ jobs:
- name: trigger spaces deploy workflow
env:
GITHUB_TOKEN: ${{ secrets.COMMENT_TOKEN }}
run: gh workflow run build-pr.yml
run: gh workflow run deploy-spaces.yml

0 comments on commit 37d4700

Please sign in to comment.