Skip to content

Commit

Permalink
only start listening for events after the components are mounted (#5312)
Browse files Browse the repository at this point in the history
* only start listening for events after the components are mounted

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
  • Loading branch information
2 people authored and dawoodkhan82 committed Aug 28, 2023
1 parent 0958038 commit 8972cb9
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 37 deletions.
6 changes: 6 additions & 0 deletions .changeset/large-bats-say.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@gradio/app": patch
"gradio": patch
---

fix:only start listening for events after the components are mounted
72 changes: 35 additions & 37 deletions js/app/src/Blocks.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -515,43 +515,6 @@
}
});
render_complete = true;
}
function handle_destroy(id: number): void {
handled_dependencies = handled_dependencies.map((dep) => {
return dep.filter((_id) => _id !== id);
});
}
$: set_status($loading_status);
dependencies.forEach((v, i) => {
loading_status.register(i, v.inputs, v.outputs);
});
function set_status(statuses: LoadingStatusCollection): void {
for (const id in statuses) {
let loading_status = statuses[id];
let dependency = dependencies[loading_status.fn_index];
loading_status.scroll_to_output = dependency.scroll_to_output;
loading_status.show_progress = dependency.show_progress;
set_prop(instance_map[id], "loading_status", loading_status);
}
const inputs_to_update = loading_status.get_inputs_to_update();
for (const [id, pending_status] of inputs_to_update) {
set_prop(instance_map[id], "pending", pending_status === "pending");
}
}
const target_map: Record<number, Record<string, number[]>> = {};
function isCustomEvent(event: Event): event is CustomEvent {
return "detail" in event;
}
onMount(() => {
dependencies.forEach((dep, i) => {
let { targets, trigger, inputs, outputs } = dep;
const target_instances: [number, ComponentMeta][] = targets.map((t) => [
Expand Down Expand Up @@ -588,7 +551,42 @@
trigger_api_call(dep_id, data);
});
});
render_complete = true;
}
function handle_destroy(id: number): void {
handled_dependencies = handled_dependencies.map((dep) => {
return dep.filter((_id) => _id !== id);
});
}
$: set_status($loading_status);
dependencies.forEach((v, i) => {
loading_status.register(i, v.inputs, v.outputs);
});
function set_status(statuses: LoadingStatusCollection): void {
for (const id in statuses) {
let loading_status = statuses[id];
let dependency = dependencies[loading_status.fn_index];
loading_status.scroll_to_output = dependency.scroll_to_output;
loading_status.show_progress = dependency.show_progress;
set_prop(instance_map[id], "loading_status", loading_status);
}
const inputs_to_update = loading_status.get_inputs_to_update();
for (const [id, pending_status] of inputs_to_update) {
set_prop(instance_map[id], "pending", pending_status === "pending");
}
}
const target_map: Record<number, Record<string, number[]>> = {};
function isCustomEvent(event: Event): event is CustomEvent {
return "detail" in event;
}
</script>

<svelte:head>
Expand Down

0 comments on commit 8972cb9

Please sign in to comment.