Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce <label> html tag to components that use label input #5454

Closed
fazpu opened this issue Sep 8, 2023 · 1 comment · Fixed by #5864
Closed

Introduce <label> html tag to components that use label input #5454

fazpu opened this issue Sep 8, 2023 · 1 comment · Fixed by #5864
Labels
good first issue Good for newcomers refactor Involves refactoring existing code svelte Frontend-related issue (JS)
Milestone
Component Cleanup

Comments

@fazpu
Copy link
Contributor

fazpu commented Sep 8, 2023 •
edited

Hi!

I tried to override the label styling via css. I was only partly successful, because only some components use label html tag (see the lighter vs darker fields). It would be very useful if all the the components that accept label as an input used <label> tag.

The offenders are at least File and Chatbot, but there will be more.

You can see what I'm trying to do here - https://github.com/h2oai/h2ogpt/pull/818/files.

image
@abidlabs
Copy link
Member

abidlabs commented Sep 8, 2023

We can take a look at this, thanks @fazpu

@abidlabs abidlabs added the refactor Involves refactoring existing code label Sep 8, 2023
@abidlabs abidlabs added this to the Component Cleanup milestone Sep 8, 2023
@fazpu fazpu mentioned this issue Sep 11, 2023
Merged
@abidlabs abidlabs self-assigned this Sep 28, 2023
@abidlabs abidlabs added good first issue Good for newcomers svelte Frontend-related issue (JS) hacktoberfest labels Oct 2, 2023
@abidlabs abidlabs removed their assignment Oct 6, 2023
@aileenvl aileenvl mentioned this issue Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Involves refactoring existing code svelte Frontend-related issue (JS)
Projects
None yet
Milestone
Component Cleanup
Development

Successfully merging a pull request may close this issue.

Change BlockLabel element to use <label> aileenvl/gradio
2 participants
@abidlabs @fazpu