Change BlockLabel element to use <label>
#5864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent BlockLabel is being used as the main component for labels and should address the issue reported in Chat and File component closes issue 5454
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
hannahblair
reviewed
Oct 11, 2023
|
Thanks so much for contributing this @aileenvl! I have a small suggestion above |
Co-authored-by: Hannah <hannahblair@users.noreply.github.com>
hannahblair
changed the title
BlocksLabel element to use <label>
hannahblair
changed the title
BlocksLabel element to use <label>BlocksLabel element to use <label>
hannahblair
changed the title
BlocksLabel element to use <label>BlockLabel element to use <label>
|
Thanks for making that change! We should change the |
hannahblair
reviewed
Oct 12, 2023
Change CSS styles from div to label selector in BlockLabel
|
Thanks so much for contributing this change @aileenvl! LGTM :) |
This was referenced Oct 12, 2023
Merged
|
Hey @aileenvl! We wanted to reach out to thank you for your contributions to gradio. We're giving away Hugging Face merch to contributors during Hacktoberfest, and we'd like to send you something! Would you be able to send an email to team@gradio.app so we can get in touch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: change to label tag where label property is accepted by component
BlockLabel is being used as the main component for labels and should address the issue reported in Chat and File component
closes issue 5454
Description
all the the components that accept label as an input used tag.
Closes: #5454
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh