Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially add more configurations to the footer / make it expand into a menu? #785

Open
abidlabs opened this issue Mar 7, 2022 · 3 comments
Open

Potentially add more configurations to the footer / make it expand into a menu? #785

abidlabs opened this issue Mar 7, 2022 · 3 comments
Labels
enhancement New feature or request svelte Frontend-related issue (JS)

Comments

@abidlabs
Copy link
Member

abidlabs commented Mar 7, 2022 •
edited

We need to add a footer to Blocks or Interface made from Blocks. We could potentially use this opportunity to build out the Gradio footer a little more. It could provide users with:

  • ability to toggle between supported languages
  • ability to switch between dark/light mode
  • ability to generate an embed link (maybe?)
  • ability to record a GIF / screencaste (maybe?)
  • ability to view the API docs (already implemented)

To support all this without taking up too much real estate, we should consider redesigning the footer so that these options appear in a menu when you click on the footer.
@abidlabs abidlabs added the enhancement New feature or request label Mar 7, 2022
@abidlabs abidlabs changed the title Add more configurations in Gradio footer / make it expand into a menu? [blocks-dev] Add more configurations in Gradio footer / make it expand into a menu? Mar 30, 2022
@abidlabs abidlabs added this to the blocks-priority milestone Mar 30, 2022
@abidlabs
Copy link
Member Author

Moving this to blocks-dev as we need to bring back the footer, so we could tackle (some of) these there

@abidlabs abidlabs changed the title [blocks-dev] Add more configurations in Gradio footer / make it expand into a menu? [blocks-dev] Add a footer. Potentially add more configurations / make it expand into a menu? Apr 1, 2022
@abidlabs
Copy link
Member Author

abidlabs commented Apr 9, 2022

@dawoodkhan82 based on our discussion today, I would just add a simple "built with Gradio" type footer for now.

We can add other menu options like the view API (which needs to be rewritten anyways with the new endpoints) and i18n toggle later after the more detailed redesign.

@dawoodkhan82 dawoodkhan82 mentioned this issue Apr 11, 2022
Merged
6 tasks
abidlabs added a commit that referenced this issue Apr 13, 2022
@dawoodkhan82 @abidlabs
Issue #785: add footer (#972)
eebe7b5 
* add footer

* fix logo align

* frontend

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
@abidlabs
Copy link
Member Author

abidlabs commented Apr 13, 2022 •
edited

Updating the issue since it is no longer a blocker for merging blocks-dev into main thanks to #972 , but it still has useful suggestions for the future

@abidlabs abidlabs changed the title [blocks-dev] Add a footer. Potentially add more configurations / make it expand into a menu? Potentially add more configurations to the footer / make it expand into a menu? Apr 13, 2022
@abidlabs abidlabs removed this from the blocks-priority milestone Apr 13, 2022
@abidlabs abidlabs mentioned this issue Apr 25, 2022
Closed
@abidlabs abidlabs mentioned this issue May 9, 2022
Merged
@abidlabs abidlabs mentioned this issue Jun 1, 2022
Merged
@omerXfaruq omerXfaruq mentioned this issue Jun 9, 2022
Closed
1 task
@abidlabs abidlabs added the svelte Frontend-related issue (JS) label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request svelte Frontend-related issue (JS)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abidlabs @dawoodkhan82