Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read version.txt #1631

Merged
merged 2 commits into from Jun 25, 2022
Merged

Read version.txt #1631

merged 2 commits into from Jun 25, 2022

Conversation

abidlabs
Copy link
Member

In setup.py, this reads the version from version.txt to have a single source of truth.

Closes: #1629

pngwn
pngwn approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@abidlabs abidlabs merged commit 0f44cf8 into main Jun 25, 2022
@abidlabs abidlabs deleted the version branch June 25, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pngwn pngwn pngwn approved these changes

@omerXfaruq omerXfaruq Awaiting requested review from omerXfaruq

@aliabid94 aliabid94 Awaiting requested review from aliabid94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy to pypi GitHub action does not push changed files to main
2 participants
@abidlabs @pngwn