Allow gr.Templates to take in arguments
#2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2600-all-demos |
gradio/templates.py
Outdated
| @@ -97,7 +106,9 @@ class Pil(components.Image): | |||
| is_template = True | |||
|
|
|||
| def __init__(self, **kwargs): | |||
There was a problem hiding this comment.
Wouldn't it be better if we specified the kwargs the class supports as opposed to accepting arbitrary kwargs?
Right now you could do gr.Pil(type="numpy") which is confusing/defeats the purpose of the template. Also means devs won't get hints from their editors and makes it easy to make a typo and only be aware at runtime.
There was a problem hiding this comment.
Ah yeah you're right. I think it's okay to override the template params but you're right it would be good to specify them explicitly
|
Fixed now, thanks for the suggestion @freddyaboulton! |
freddyaboulton
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix to
gr.Templatesso that they can take in arguments. Fixes: #2595