Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup colab #2612

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Cleanup colab #2612

merged 6 commits into from
Nov 18, 2022

Conversation

aliabid94
Copy link
Collaborator

@aliabid94 aliabid94 commented Nov 7, 2022

Cleanup Colab embedding in two ways:

  1. Shorten Colab message.

Screen Shot 2022-11-07 at 7 31 34 AM

  1. Remove printed outputs after launch, see screenshot below. Did this by extending tuple class and override __repr__.

BEFORE
Screen Shot 2022-11-07 at 7 23 39 AM

AFTER
Screen Shot 2022-11-07 at 7 32 01 AM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2612-all-demos

gradio/strings.py Outdated Show resolved Hide resolved
@abidlabs
Copy link
Member

abidlabs commented Nov 10, 2022

Looks good, thanks @aliabid94! Given that we have heard very very few bugs / complaints about embedded mode, I believe it's safe to go with this shorter message

aliabid94 and others added 2 commits November 18, 2022 06:47
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
@aliabid94 aliabid94 merged commit 6798ea3 into main Nov 18, 2022
@aliabid94 aliabid94 deleted the cleanup_colab branch November 18, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants