Fix loading interface with examples #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2640-all-demos |
freddyaboulton
force-pushed
the
2638-load-with-examples
branch
from
476144b
to
025a9b2
Compare
freddyaboulton
requested review from
abidlabs,
aliabid94,
aliabd,
dawoodkhan82 and
pngwn
and removed request for
abidlabs and
aliabid94
|
Thanks for creating this PR @freddyaboulton! Agreed that this would fix the issue in all new Spaces created, but this doesn't solve the bug for loading existing Spaces that have examples. I think we should fix that as well -- is that possible? I.e. if you run import gradio as gr
io = gr.Interface.load("spaces/abidlabs/test-calculator-2")with this branch, it still doesn't work |
|
Good point @abidlabs ! Modified
|
abidlabs
reviewed
Nov 15, 2022
| @@ -296,6 +296,8 @@ async def cache(self) -> None: | |||
| if self.batch: | |||
| output = [value[0] for value in output] | |||
| cache_logger.flag(output) | |||
| Context.root_block.dependencies.remove(dependency) | |||
There was a problem hiding this comment.
It might be good to add a comment here similar to what you added in blocks.py to explain why we're removing the dependency
There was a problem hiding this comment.
Done - thanks @abidlabs !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2638
Test with: https://huggingface.co/spaces/freddyaboulton/calculator. This is a space created with this PR.
Checklist:
A note about the CHANGELOG
Hello 馃憢 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.