-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI update: API documentation page #2652
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2652-all-demos |
ui/packages/app/src/Blocks.svelte
Outdated
</div> | ||
• | ||
View <img src={api_logo} alt="" class="w-2.5 md:w-3 mx-1" />API | ||
documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I think this should be tweaked so that the icons are not in the middle of the text. Perhaps "Use as API" instead of "View API documentation"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe "Use this app API" to focus that it's this app's API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not sure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went with "Use via API", open to suggestions
</div> | ||
<button | ||
on:click={run.bind(null, dependency_index)} | ||
class="gr-button gr-button-lg gr-button-primary w-full mt-4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha I feel like at this point we're just recreating gradio in the api page :P
Absolutely love the new look @gary149! |
Co-authored-by: Victor Muštar <victor.mustar@gmail.com>
…to doc_postman
Should work with every component now, ready for review |
Love the new design of the footer and API page! @aliabid94 I just built the frontend to test locally and I'm running into this weird behavior where the modal pops up when the Gradio app is running inside of an iframe (e.g. on Spaces or in a jupyter notebook), but not if it is opened in a new browser tab. See here: Tested on Chrome + Edge, including incognito. Also tested when launching the Interface from a regular script instead of from a jupyter notebook. Are you able to reproduce? |
Thanks for the fix @aliabid94, this is working now for me. Generally works great across many different demos. I noticed a few small UI improvements/nits:
|
New footer (we can grayscale icons color if too visible, and keep the colors on hover):
New doc page:
Dark mode: