Quick fix to gr.utils.validate_url
#2659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: we use
gr.utils.validate_url
to determine if a string is a URL or a filepath. The logic is quite simple -- we make a GET request to the URL and see if we get a result.However, some common media hosting sites (e.g. WikiCommons) require a User Agent to be set when making a request -- otherwise, the request is immediately rejected. This fact causes
gr.utils.validate_url
to fail for these URLs. In addition, since we were checking for a strict 200 response, URLs that redirected to other URLs would fail.This PR fixes those issues and add tests.
Code to reproduce: