Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pt-br.json #2753

Merged
merged 11 commits into from Dec 9, 2022
Merged

Add pt-br.json #2753

merged 11 commits into from Dec 9, 2022

Conversation

pstwh
Copy link
Contributor

@pstwh pstwh commented Dec 1, 2022

Brazilian Portuguese JSON language file.

Description

Please include:

  • relevant motivation
  • a summary of the change
  • which issue is fixed.
  • any additional dependencies that are required for this change.

Closes: # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@freddyaboulton
Copy link
Collaborator

Thank you @pstwh ! Can you please update the CHANGELOG?

@@ -0,0 +1,22 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to rename to pt-br.json for the test to pass!

CHANGELOG.md Outdated
@@ -104,6 +104,7 @@ No changes to highlight.
* Make try examples button more prominent by [@aliabd](https://github.com/aliabd) in [PR 2705](https://github.com/gradio-app/gradio/pull/2705)
* Fix id clashes in docs by [@aliabd](https://github.com/aliabd) in [PR 2713](https://github.com/gradio-app/gradio/pull/2713)
* Fix typos in guide docs by [@andridns](https://github.com/andridns) in [PR 2722](https://github.com/gradio-app/gradio/pull/2722)
* Add pt-br.json by [@pstwh](http://github.com/pstwh) in [PR 2753](https://github.com/gradio-app/gradio/pull/2753)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be higher up in the changelog, in the "Upcoming Release" section, not in the "3.12.0" section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, sorry for my inattention.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks for the fix!

CHANGELOG.md Outdated Show resolved Hide resolved
@abidlabs
Copy link
Member

abidlabs commented Dec 5, 2022

@pstwh would you be able to make the addition @freddyaboulton requested? Then should be good to merge. Thank you!

@abidlabs
Copy link
Member

abidlabs commented Dec 9, 2022

I'll take the liberty to add the image to the changelog so that we can merge this in. Thanks @pstwh for the translations!

@abidlabs abidlabs merged commit 728f3a9 into gradio-app:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants