New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove footers and min-height the correct way #2860
Conversation
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
1 similar comment
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2860-all-demos |
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
You can see my struggle above with the demo notebooks action, but it turned out there was actually a problem. Locally I had a Will add |
Beautiful, looks great @aliabd! Can you just verify one thing: The embedded demos in "try examples" are not working for me on staging. For example: https://www.gradio-staging.com/docs/main/#radio, when I click try examples, I get this: They are working if I set the toggle to 3.14.0, as well as on www.gradio.app/docs. But I can't see what it might have to do with your change. If they are working for you, then I assume it's something weird on my device and the PR looks good to merge, but if they aren't, then we should investigate |
@abidlabs there's an issue with the spaces themselves, and not all of them. Just some of the |
@abidlabs that is to say, those demos are also broken on gradio.app/main |
The footers and min-height on embedded components in the docs create annoying space and ruin the flow. We've been removing them with js on the page but it hasn't been reliable and often doesn't work because the components load late. This removes them using css inside the demos themselves. Live on staging
Closes: #2827