Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove footers and min-height the correct way #2860

Merged
merged 10 commits into from Dec 21, 2022
Merged

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Dec 20, 2022

The footers and min-height on embedded components in the docs create annoying space and ruin the flow. We've been removing them with js on the page but it hasn't been reliable and often doesn't work because the components load late. This removes them using css inside the demos themselves. Live on staging

Closes: #2827

@github-actions
Copy link
Contributor

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

1 similar comment
@github-actions
Copy link
Contributor

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

@github-actions
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2860-all-demos

@github-actions
Copy link
Contributor

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

@github-actions
Copy link
Contributor

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

@aliabd aliabd requested review from abidlabs and aliabid94 and removed request for abidlabs December 20, 2022 17:52
@github-actions
Copy link
Contributor

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

@github-actions
Copy link
Contributor

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

@github-actions
Copy link
Contributor

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

@github-actions
Copy link
Contributor

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

@aliabd
Copy link
Collaborator Author

aliabd commented Dec 20, 2022

You can see my struggle above with the demo notebooks action, but it turned out there was actually a problem. Locally I had a gradio_cached_examples folder in fake_gan (for some reason), so when generating the notebook it thought that was a file the demo needed to run, and added a wget for it. But gradio_cached_examples is in gitignore, so when the commands are run from the action there's no wget and it causes the fail.

Will add gradio_cached_examples to list of files to ignore when notebooks are generated (in a separate PR)

@abidlabs
Copy link
Member

abidlabs commented Dec 20, 2022

Beautiful, looks great @aliabd! Can you just verify one thing:

The embedded demos in "try examples" are not working for me on staging.

For example: https://www.gradio-staging.com/docs/main/#radio, when I click try examples, I get this:
image

They are working if I set the toggle to 3.14.0, as well as on www.gradio.app/docs. But I can't see what it might have to do with your change. If they are working for you, then I assume it's something weird on my device and the PR looks good to merge, but if they aren't, then we should investigate

@aliabd
Copy link
Collaborator Author

aliabd commented Dec 21, 2022

@abidlabs there's an issue with the spaces themselves, and not all of them. Just some of the _main spaces (the versioned ones don't get updated except on new releases). For some reason many of the _main spaces returned a build error. Will try again and if there's still a problem will check with the spaces team. Unrelated to embedding or this PR though so I will merge

@aliabd
Copy link
Collaborator Author

aliabd commented Dec 21, 2022

@abidlabs that is to say, those demos are also broken on gradio.app/main

@aliabd aliabd merged commit dc200af into main Dec 21, 2022
@aliabd aliabd deleted the aliabd/remove-footers branch December 21, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly remove footers from embedded components in the docs
2 participants