replace x-png with png #3002
Merged
replace x-png with png #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3002-all-demos |
|
I think we'll need to test on ubuntu. On my mac with Chrome I'm able to upload a png on main |
freddyaboulton
approved these changes
Jan 17, 2023
freddyaboulton
approved these changes
Jan 17, 2023
dawoodkhan82
approved these changes
Jan 17, 2023
|
Awesome thanks @freddyaboulton @dawoodkhan82 and @pcuenca for the feedback! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got some feedback recently to replace the outdated x-png MIME type with the now standard png MIME type.
I believe this closes: #2110 but if someone with a Mac/Ubuntu could confirm, that would be great