LaTeX height fix #3258
Merged
LaTeX height fix #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3258-all-demos |
|
Here's another example:
|
aliabid94
approved these changes
Feb 21, 2023
| @@ -34,6 +34,8 @@ | |||
|
|
|||
| div :global(.math.inline svg) { | |||
| display: inline; | |||
| margin-bottom: 0.15em; | |||
There was a problem hiding this comment.
margin-bottom: 0.25em looks better to me, seems like it hangs under the baseline at 0.15em
|
Yeah I agree, thanks for the review and suggestion @aliabid94! Here's how it looks with 0.25em;
Splitting hairs at this point, but here's how it looks with 0.22em, which looks better to me:
|
|
Isn't the paragraph level text basically unreadable now? I think that will be one of the more common contexts for this syntax too. |
|
@aliabid94 actually just said the same thing. When the LaTeX is multi-level (fractions, integral), it becomes unreadable. Let me fix this |
dawoodkhan82
pushed a commit
that referenced
this pull request
Feb 22, 2023
* latex height fix * changelog * formatting * em * em
dawoodkhan82
added a commit
that referenced
this pull request
Feb 23, 2023
* dropdown * more dropdown updates * dropdown styling + option visibility * changelog * notebook * fix test * Allow more image formats (#3225) * add wildcard to image input * simplify mime types * changelog * regen noteboks --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: pngwn <hello@pngwn.io> * fix webcam mirroring (#3245) * fix webcam * changelog * fix changelog * fix changelog * fix changelog --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Add `interactive=False` mode to `gr.Button` (#3266) * add interactive=False to button * add interactive=True by default * changelog * fix frontend * fix backend test * formatting * review changes * LaTeX height fix (#3258) * latex height fix * changelog * formatting * em * em * accidentally added script (#3273) * Adding a script to benchmark the queue (#3272) * added benchmark queue script * changelg * fix instructions * Fix matplotlib image size (#3274) * Fix matplotlib css * CHANGELOG * Undo lockfile * Add timeouts to queue messages (#3196) * Fix + test * Remove print statements + fix import for 3.7 * CHANGELOG * Remove more print statements * Add 60 second timeout for uploading data * Fix test --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * icons * separate options into component * formatting * changelog * changelog * fix ui tests * formatting again... * backend test fix * format * doc fixes --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: fienestar <fienestar@gmail.com> Co-authored-by: pngwn <hello@pngwn.io> Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LaTeX heights so that they are set based on the height of surrounding text instead of being hardcoded by the rendering engine. Fixes: #3243
Before:
After: