New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: only run backend lints once, not in all test environments #3960
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3960-all-demos |
2e0ff36
to
6d33c04
Compare
Hi @akx thanks yet again! This change looks fine to me, but let's run linting before we run the tests. Linting is much faster than running the tests, so better for it to fail quickly if the code is not linted rather than having to wait for all of the tests to run |
@abidlabs @freddyaboulton Done deal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akx !
Can't update the branch and merge @akx - please merge in main and let me know so we can merge this in. |
a5f7794
to
1ec7e35
Compare
@freddyaboulton Rebased, tests were flaky so I re-pushed, we'll see... |
Hi @akx - can you reopen the PR and allow edits from maintainers? That way I can merge in main and get this merged! Otherwise might be tricky to align on timing |
@freddyaboulton Sorry, enabled "allow edits" now and rebased. |
Thanks again @akx ! |
Thanks @akx for addressing the feedback! |
Description
No need to spend cycles running lints multiple times; just run it once in a separate step.
Checklist: