Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url_ok check is not reaching host #408

Merged
merged 5 commits into from Dec 15, 2021

Conversation

cansik
Copy link
Contributor

@cansik cansik commented Dec 14, 2021

As discussed in #382 , this fixes the case if the server_name is set to 0.0.0.0.

I have introduced a new variable called url_host_name, which is used as host name for the url (not the flask server). The variable is set to either the defined server_name or localhost.

@height
Copy link

height bot commented Dec 14, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@abidlabs abidlabs merged commit b12ac1d into gradio-app:master Dec 15, 2021
@abidlabs
Copy link
Member

LGTM @cansik thanks for taking the time to describe the issue in detail and make the fix. All tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants