Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load iframe resizer asynchronously #4336

Merged
merged 4 commits into from Jun 19, 2023
Merged

Conversation

akx
Copy link
Contributor

@akx akx commented May 25, 2023

Description

Please include:

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@gradio-pr-bot
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4336-all-demos

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akx!

@pngwn
Copy link
Member

pngwn commented May 30, 2023

This is causing the browser tests to fail and I'm not entirely sure why. Gradio itself works fine. Will take a look later today.

@pngwn
Copy link
Member

pngwn commented Jun 19, 2023

We've changed how we do browser tests around a bit which seems to have resolved everything here.

Sorry for the delay and thanks again @akx!

@pngwn pngwn merged commit 1068371 into gradio-app:main Jun 19, 2023
8 checks passed
@akx akx deleted the async-iframe-resizer branch June 27, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants