Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize unnecessary uses of new Promise() #4442

Merged
merged 3 commits into from Jun 8, 2023
Merged

Optimize unnecessary uses of new Promise() #4442

merged 3 commits into from Jun 8, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Jun 7, 2023

Description

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@akx akx changed the title Fix unnecessary uses of new Promise() Optimize unnecessary uses of new Promise() Jun 7, 2023
@akx akx force-pushed the js-cleanup-new-promise branch 2 times, most recently from 776f740 to 62f806f Compare June 7, 2023 06:31
@gradio-pr-bot
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4442-all-demos

@pngwn
Copy link
Member

pngwn commented Jun 7, 2023 •
edited

I don't think this is an optimisation in any meaningful sense, but I agree it is much cleaner.

pngwn
pngwn approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @akx!

@pngwn pngwn merged commit 9c5a1d8 into gradio-app:main Jun 8, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pngwn pngwn pngwn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akx @gradio-pr-bot @pngwn