implement autoplay for Video and Audio #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pngwn
commented
Jun 8, 2023
Comment on lines
+36
to
+48
| let el: HTMLAudioElement; | ||
|
|
||
| let old_val: any; | ||
| function value_has_changed(val: any) { | ||
| if (val === old_val) return false; | ||
| else { | ||
| old_val = val; | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| $: autoplay && el && value_has_changed(value) && el.play(); | ||
|
|
There was a problem hiding this comment.
I don't love the duplication but its ok for now, we should create a static AudioPlayer like we have withe Video to abstract this at some point.
pngwn
commented
Jun 8, 2023
Comment on lines
-21
to
22
| let show_controls = true; | ||
| let show_controls_timeout: NodeJS.Timeout; | ||
|
|
||
| function video_move() { | ||
| clearTimeout(show_controls_timeout); | ||
| show_controls_timeout = setTimeout(() => (show_controls = false), 500); | ||
| show_controls = true; | ||
| } | ||
|
|
||
| function handleMove(e: TouchEvent | MouseEvent) { |
There was a problem hiding this comment.
This is all just unused code from a previous change.
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4453-all-demos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1349.
Implements
autoplaykwarg for Audio and Video.Can test with this:
This will work in most cases but it won't work on page load because browsers disallow it. There are workaround (although they are pretty messy) but it is obnoxious anyway, so i think it is fine that it doesn't work.
Please include:
Closes: # (issue)
Checklist:
A note about the CHANGELOG
Hello 馃憢 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.