Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some BarPlot Fixes #4531

Merged
merged 4 commits into from Jun 15, 2023
Merged

Some BarPlot Fixes #4531

merged 4 commits into from Jun 15, 2023

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Jun 15, 2023

Description

Closes: #4530 Closes: #4529

To test, run native_plots in dark mode and note that the label for the bar plot does not show up and that the plot text is white when you select grouped or grouped-horizontal int the bar plot tab.

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

A note about the CHANGELOG

Hello 馃憢 and thank you for contributing to Gradio!

All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.

Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by [@myusername](link-to-your-github-profile) in [PR 11111](https://github.com/gradio-app/gradio/pull/11111)".

If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.

@gradio-pr-bot
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4531-all-demos

@freddyaboulton freddyaboulton marked this pull request as ready for review June 15, 2023 18:00
@abidlabs
Copy link
Member

Can confirm the fixes, thank you @freddyaboulton!

@freddyaboulton
Copy link
Collaborator Author

Thanks @abidlabs !

@freddyaboulton freddyaboulton merged commit e0a7f87 into main Jun 15, 2023
13 checks passed
@freddyaboulton freddyaboulton deleted the barplot-fixes branch June 15, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show_label for BarPlot does not work Some plot text in native plots does not display well in dark mode
3 participants