Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatbot streaming hotfix #4537

Merged
merged 4 commits into from Jun 15, 2023
Merged

Chatbot streaming hotfix #4537

merged 4 commits into from Jun 15, 2023

Conversation

aliabid94
Copy link
Collaborator

@aliabid94 aliabid94 commented Jun 15, 2023

Chatbot streaming broke as a result of latex changes, because the rendered Markdown only rendered onMount, and did not react to message changes. Changed to afterUpdate

Run demo/chatbot_streaming to see fix.

Fixes: #4534

@aliabid94 aliabid94 requested a review from pngwn June 15, 2023 20:09
@gradio-pr-bot
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4537-all-demos

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this fix the streaming case and to my knowledge it doesn't break any of the other chatbot demos.

@aliabid94 aliabid94 merged commit 42d762c into main Jun 15, 2023
13 checks passed
@aliabid94 aliabid94 deleted the chatbot_hotfix branch June 15, 2023 20:24
@pngwn
Copy link
Member

pngwn commented Jun 15, 2023

Ah, thanks for catching that!

@redrocket8
Copy link

If the string has latex code then the latex code is not rendered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradio 3.35.0 breaks gr.Chatbot streaming
5 participants