Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix modal position #4538

Merged
merged 2 commits into from Jun 15, 2023
Merged

fix modal position #4538

merged 2 commits into from Jun 15, 2023

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Jun 15, 2023 •
edited

Description

Fixes the error modal position. I've also bumped the text size on the error modal because at 12px it is borderline unreadable.

@gradio-pr-bot
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4538-all-demos

freddyaboulton
freddyaboulton approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pngwn ! Thank you

error_modal

@hannahblair
Copy link
Collaborator

Tested! Works on smaller screens now 👍

@pngwn pngwn merged commit 9793534 into main Jun 15, 2023
10 checks passed
@pngwn pngwn deleted the modal-position branch June 15, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahblair hannahblair hannahblair approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pngwn @gradio-pr-bot @hannahblair @freddyaboulton