Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore some missing imports in __init__ #4566

Merged
merged 5 commits into from Jun 19, 2023
Merged

Restore some missing imports in __init__ #4566

merged 5 commits into from Jun 19, 2023

Conversation

abidlabs
Copy link
Member

Closes: #4564

@abidlabs abidlabs changed the title import init Restore some missing imports in __init__ Jun 19, 2023
@gradio-pr-bot
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4566-all-demos

Comment on lines +5 to +10
Column,
Component,
Form,
FormComponent,
IOComponent,
Row,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better for users to import Column, Form, and Row from gr.layouts instead of gr.components, but for the sake of backwards compatibility, I have included them here

Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can deprecate this in 4.0.

@abidlabs
Copy link
Member Author

Thanks @aliabid94!

@abidlabs abidlabs merged commit ee313c6 into main Jun 19, 2023
11 checks passed
@abidlabs abidlabs deleted the comp-init branch June 19, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradio 3.35.2 breaks compatibility due to missing components
3 participants