Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Image): Image mod is mask or color-sketch bug; #4692

Merged
merged 7 commits into from Jun 28, 2023
Merged

Conversation

AmyOrz
Copy link
Contributor

@AmyOrz AmyOrz commented Jun 27, 2023

click undo -> the shadow line not real time change

Description

ok, I will provide more information for you.
in the gradio/demo/blocks_mask -> io3a, io3b, io5a demo has the same bug:

  1. first time I draw 3 line in canvas, get this result:
    image
    2.then i click the undo icon and draw other line, click submit button get this result:
    image
    3.click undo icon, two line is disappear. click submit button get error result;
    image

in the gradio/demo/blocks_mask -> io3a and io3b demo.

Operate the above three steps, get the error result: the black background image;
image

@gradio-pr-bot
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4692-all-demos

@pngwn
Copy link
Member

pngwn commented Jun 28, 2023

Have confirmed the bug and the fix.

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the detailed reproduction steps and the fix @AmyOrz!

@pngwn pngwn merged commit dc733f4 into gradio-app:main Jun 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants